[PATCH] D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly.

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 07:54:14 PDT 2022


simon_tatham updated this revision to Diff 453011.
simon_tatham added a comment.
Herald added a subscriber: emaste.

Added another test to check that the new data vs code priorities work.

I'd misunderstood the previous sorting criterion, it turned out. I
thought symbols at the same address were sorted by type. In fact
they're sorted by name, //then// by type. So out of a data and code
symbol, the alphabetically later one was previously winning!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131589/new/

https://reviews.llvm.org/D131589

Files:
  llvm/test/tools/llvm-objdump/ELF/data-vs-code-priority.test
  llvm/test/tools/llvm-objdump/multiple-symbols.test
  llvm/tools/llvm-objdump/ObjdumpOpts.td
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131589.453011.patch
Type: text/x-patch
Size: 22967 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220816/f52669ac/attachment.bin>


More information about the llvm-commits mailing list