[PATCH] D131672: [instcombine] Optimise for zero initialisation of product given fast flags are enabled

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks for the update! Could you also update the description to describe the transformation implemented, with the legality considerations as well?



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp:487
 
+  PHINode *PN = nullptr;
+  Value *Start = nullptr, *Step = nullptr;
----------------
Could you add a comment explaining the transform we are applying here? Also, it would probably be good to move this more towards the end of the function, so cheaper patterns are tried first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131672/new/

https://reviews.llvm.org/D131672