[PATCH] D130164: [LV] Support predicated div/rem operations via safe-divisor select idiom

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8361
+    // a block, otherwise we'd need to prove speculation safety without explicit
+    // block predication.  If that assumption is ever invalidated, this code needs
+    // updated.
----------------
fhahn wrote:
> Do you know if there's an easy way to assert this here? Seems like something that could be easily missed.
I don't, and this a pretty prevalent assumption in the code already.  e.g. all predicated store/load handling does the same.

If anything, I might lean towards removing the comment as it may falsely give the impression the assumption is unique to this code.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130164/new/

https://reviews.llvm.org/D130164