[PATCH] D131347: Set up basic infrastructure for ELF/i386 backend support in JITLink .

[Kshitij Jain via Phabricator via llvm-commits]

jain98 added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_i386.cpp:66
+    LLVM_DEBUG(dbgs() << "Adding relocations\n");
+    using Base = ELFLinkGraphBuilder<ELFT>;
+
----------------
chapuni wrote:
> Unused?
Yes. It looks like it's been fixed


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_i386.cpp:66
+    LLVM_DEBUG(dbgs() << "Adding relocations\n");
+    using Base = ELFLinkGraphBuilder<ELFT>;
+
----------------
jain98 wrote:
> chapuni wrote:
> > Unused?
> Yes. It looks like it's been fixed
Yes looks like  it's been fixed here - https://github.com/llvm/llvm-project/commit/eca990702d5676151419655098afb57b22cab600


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131347/new/

https://reviews.llvm.org/D131347