[PATCH] D131958: Add all constant physical registers to callee preserved masks

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.

Makes sense to me but somebody else should give it a more thorough review.

> To avoid having to manually add the zero registers to all CalleeSavedRegs instantiations in tablegen,

It seems wise to avoid that approach, even if that also would have worked.



================
Comment at: llvm/test/CodeGen/Mips/avoid-zero-copy.mir:12-13
   ; ASM-NEXT:    jalr $25
   ; ASM-NEXT:    move $4, $zero
-  ; ASM-NEXT:    move $4, $16
-  ; ASM-NEXT:    ld $16, 0($sp) # 8-byte Folded Reload
+  ; ASM-NEXT:    move $4, $zero
   ; ASM-NEXT:    ld $ra, 8($sp) # 8-byte Folded Reload
----------------
arichardson wrote:
> luismarques wrote:
> > Redundant move
> The previous one is in the delay-slot, so it's actually setting the argument register a0.
Oops, ignore this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131958/new/

https://reviews.llvm.org/D131958