[PATCH] D131672: [instcombine] Optimise for zero initialisation of product given fast flags are enabled
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 16 04:55:48 PDT 2022
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM - see inline comment for formatting nit.
The tests seem fine too, but let @fhahn have another look in case there are any other suggestions.
I'm not sure what source causes this pattern, but there could be related fast-math simplifications like `X * 1.0 --> X`.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp:492
+ return replaceInstUsesWith(I, Start);
+ }
+
----------------
Remove braces around one-line 'if' clause to be consistent with surrounding code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131672/new/
https://reviews.llvm.org/D131672
More information about the llvm-commits
mailing list