[PATCH] D128212: [DebugInfo] Extend the InstrRef LDV to support DbgValues with many Ops

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.

Still LGTM!



================
Comment at: llvm/test/DebugInfo/MIR/X86/live-debug-values-reg-copy.mir:12
 # CHECK: $r12d = MOV32rr killed $ebx, implicit-def $r12
+# CHECK-NEXT: DBG_VALUE_LIST !13, !DIExpression(DW_OP_LLVM_arg, 0, DW_OP_LLVM_arg, 1, DW_OP_plus), $r12d, $r13d
 # CHECK-NEXT: DBG_VALUE $r12d, $noreg, ![[ARG1]], !DIExpression(), debug-location
----------------
Hardcoded metadata here


================
Comment at: llvm/test/DebugInfo/MIR/X86/live-debug-values-reg-copy.mir:15
+# CHECK: $r10d = MOV32rr killed $r13d, implicit-def $r10
+# CHECK-NEXT: DBG_VALUE_LIST !13, !DIExpression(DW_OP_LLVM_arg, 0, DW_OP_LLVM_arg, 1, DW_OP_plus), $r12d, $r10d
 --- |
----------------
Here too


================
Comment at: llvm/test/DebugInfo/MIR/X86/live-debug-values-restore.mir:785-786
+# spilt and restored, we correctly track each value individually.
+# This third function tests that complex expressions are spilt, and restored
+# correctly within a basic block.
+
----------------
Copy paste?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128212/new/

https://reviews.llvm.org/D128212