[PATCH] D128180: [DebugInfo][InstrRef][NFC] Let LDV handle joins for lists of debug ops

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 03:12:24 PDT 2022


Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

It looks like @jmorse's comments have now been addressed - tentative LGTM



================
Comment at: llvm/unittests/CodeGen/InstrRefLDVTest.cpp:2011
   DbgValueProperties EmptyProps(EmptyExpr, false, false);
+  DIExpression* TwoOpExpr = DIExpression::get(Ctx, { dwarf::DW_OP_LLVM_arg, 0, dwarf::DW_OP_LLVM_arg, 1, dwarf::DW_OP_plus });
+  DbgValueProperties TwoOpProps(TwoOpExpr, false, true);
----------------
Please clang-format your patch before you land it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128180/new/

https://reviews.llvm.org/D128180



More information about the llvm-commits mailing list