[PATCH] D131773: [AArch64] Add support for 256-bit non temporal loads
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 16 02:16:42 PDT 2022
fhahn added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:20413
+ }
assert(SDValue(N, 0).getValueType() == MVT::i128 &&
"unexpected load's value type");
----------------
I think this assertion doesn't really make sense any longer, because we now enable the custom lowering for additional types. This probably needs to became just a check (i.e add an early exit here if the cownciditon doesn't hold). At the moment this assertion triggers in multiple tests, causing them to fail.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131773/new/
https://reviews.llvm.org/D131773
More information about the llvm-commits
mailing list