[PATCH] D119342: [LoopRotate] Don't rotate loops when the minsize attribute is present
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 16 01:52:01 PDT 2022
fhahn added a comment.
IIUC this should make LTO loop rotate behavior match the behavior when using -Oz in non-LTO, so this seems fine. Just a question about the test case. Also, it would be good to upload the diff with full context.
================
Comment at: llvm/test/Transforms/LoopRotate/minsize-disable.ll:3
+; RUN: opt < %s -S -O2 -debug -debug-only=loop-rotate 2>&1 | FileCheck %s
+; RUN: opt < %s -S -passes='default<O2>' -debug -debug-only=loop-rotate 2>&1 | FileCheck %s
+
----------------
Does this test require running the full O2 pipeline? Usually we try to only run isolated passes if possible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119342/new/
https://reviews.llvm.org/D119342
More information about the llvm-commits
mailing list