[PATCH] D131125: [Matrix] Add special case dot product lowering

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1236
+    Function *Add = Intrinsic::getDeclaration(Func.getParent(), AddOpCode,
+                                    ElementType);
+
----------------
virnarula wrote:
> thegameg wrote:
> > Not sure what's going on here. Intrinsic with `Instruction::Add`? It also doesn't seem to be really used.
> I use it to get the function type when estimating sequential add cost. line 1243. Do you suggest doing it a different way?
It looks like you only use `AddOpCode` and `Add` is only used for the type, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131125/new/

https://reviews.llvm.org/D131125