[PATCH] D131833: [ORC][COFF] Introduce DLLImportDefinitionGenerator.

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp:512
+  if (!PointerSize)
+    return std::move(PointerSize.takeError());
+  auto Endianness = getTargetEndianness(TT);
----------------
FYI, this produces build warnings:
```
[539/656] Building CXX object lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ExecutionUtils.cpp.o
/usr/local/google/home/kubak/llvm/llvm-project/llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp:512:12: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
    return std::move(PointerSize.takeError());
           ^
/usr/local/google/home/kubak/llvm/llvm-project/llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp:512:12: note: remove std::move call here
    return std::move(PointerSize.takeError());
           ^~~~~~~~~~                       ~
/usr/local/google/home/kubak/llvm/llvm-project/llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp:515:12: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
    return std::move(Endianness.takeError());
           ^
/usr/local/google/home/kubak/llvm/llvm-project/llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp:515:12: note: remove std::move call here
    return std::move(Endianness.takeError());
           ^~~~~~~~~~                      ~
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131833/new/

https://reviews.llvm.org/D131833