[PATCH] D128998: [libunwind] Handle G in personality string

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 10:17:07 PDT 2022


fmayer added inline comments.


================
Comment at: libunwind/src/DwarfInstructions.hpp:220
+        // https://github.com/torvalds/linux/blob/1930a6e739c4b4a654a69164dbe39e554d228915/arch/arm64/kernel/signal.c#L718
+        p &= ~15ULL;
+        // CFA is the bottom of the current stack frame.
----------------
MaskRay wrote:
> `-16ULL`
Can you explain why this is preferred? At least for me, using only bitwise operators is more intuitive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128998/new/

https://reviews.llvm.org/D128998



More information about the llvm-commits mailing list