[PATCH] D131816: [InstrProf] Add option to avoid instrumenting small functions

[Ellis Hoag via Phabricator via llvm-commits]

ellis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:297
+    "pgo-function-size-threshold", cl::Hidden,
+    cl::desc("Do not instrument functions smaller than this threshold."));
+
----------------
MaskRay wrote:
> The convention is to omit the period for help messages. Just ignore a few options in this file which do not stick with the convention.
Thanks!

I think you’ve helped me with `opt<>` before, e.g., to omit `cl::init(0)`. Is there some guide that describes the defaults and the conversions for this? Maybe we could add it to the programmers manual?

https://www.llvm.org/docs/ProgrammersManual.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131816/new/

https://reviews.llvm.org/D131816