[PATCH] D131897: [llvm-objdump --macho] Rename --dyld_info to --dyld-info
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 15 08:17:14 PDT 2022
thakis created this revision.
thakis added a reviewer: aprantl.
Herald added a subscriber: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a reviewer: MaskRay.
Herald added a project: All.
thakis requested review of this revision.
Herald added a subscriber: StephenFan.
Herald added a project: LLVM.
llvm-objdump takes foo-bar style flags, while llvm-otool takes foo_bar style
flags. dyld_info was the only exception to that.
https://reviews.llvm.org/D131897
Files:
llvm/test/Object/AArch64/chained-fixups-header.test
llvm/test/tools/llvm-objdump/MachO/dyld-info.test
llvm/test/tools/llvm-objdump/MachO/dyld_info.test
llvm/tools/llvm-objdump/ObjdumpOpts.td
Index: llvm/tools/llvm-objdump/ObjdumpOpts.td
===================================================================
--- llvm/tools/llvm-objdump/ObjdumpOpts.td
+++ llvm/tools/llvm-objdump/ObjdumpOpts.td
@@ -303,7 +303,7 @@
HelpText<"Print chained fixup information (requires --macho)">,
Group<grp_mach_o>;
-def dyld_info : Flag<["--"], "dyld_info">,
+def dyld_info : Flag<["--"], "dyld-info">,
HelpText<"Print bind and rebase information used by dyld to resolve "
"external references in a final linked binary "
"(requires --macho)">,
Index: llvm/test/tools/llvm-objdump/MachO/dyld-info.test
===================================================================
--- llvm/test/tools/llvm-objdump/MachO/dyld-info.test
+++ llvm/test/tools/llvm-objdump/MachO/dyld-info.test
@@ -1,4 +1,4 @@
-RUN: llvm-objdump --macho --dyld_info %p/Inputs/bind.macho-x86_64 \
+RUN: llvm-objdump --macho --dyld-info %p/Inputs/bind.macho-x86_64 \
RUN: | FileCheck %s --match-full-lines --strict-whitespace \
RUN: --implicit-check-not={{.}}
Index: llvm/test/Object/AArch64/chained-fixups-header.test
===================================================================
--- llvm/test/Object/AArch64/chained-fixups-header.test
+++ llvm/test/Object/AArch64/chained-fixups-header.test
@@ -1,24 +1,24 @@
REQUIRES: host-byteorder-little-endian
RUN: cat %p/../Inputs/MachO/chained-fixups.yaml \
RUN: | sed 's/__LINKEDIT: 00000000/__LINKEDIT: AB000000/' \
-RUN: | yaml2obj | not llvm-objdump --macho --dyld_info - 2>&1 \
+RUN: | yaml2obj | not llvm-objdump --macho --dyld-info - 2>&1 \
RUN: | FileCheck %s --check-prefix=HEADER1
HEADER1: truncated or malformed object (bad chained fixups: unknown version: 171)
RUN: cat %p/../Inputs/MachO/chained-fixups.yaml \
RUN: | sed 's/1000000010000000/1000000AB0000000/' \
-RUN: | yaml2obj | not llvm-objdump --macho --dyld_info - 2>&1 \
+RUN: | yaml2obj | not llvm-objdump --macho --dyld-info - 2>&1 \
RUN: | FileCheck %s --check-prefix=HEADER2
HEADER2: truncated or malformed object (bad chained fixups: unknown imports format: 171)
RUN: cat %p/../Inputs/MachO/chained-fixups.yaml \
RUN: | sed 's/20000000/01000000/' \
-RUN: | yaml2obj | not llvm-objdump --macho --dyld_info - 2>&1 \
+RUN: | yaml2obj | not llvm-objdump --macho --dyld-info - 2>&1 \
RUN: | FileCheck %s --check-prefix=HEADER3
HEADER3: truncated or malformed object (bad chained fixups: image starts offset 1 overlaps with chained fixups header)
RUN: cat %p/../Inputs/MachO/chained-fixups.yaml \
RUN: | sed 's/20000000/FF000000/' \
-RUN: | yaml2obj | not llvm-objdump --macho --dyld_info - 2>&1 \
+RUN: | yaml2obj | not llvm-objdump --macho --dyld-info - 2>&1 \
RUN: | FileCheck %s --check-prefix=HEADER4
HEADER4: truncated or malformed object (bad chained fixups: image starts end 33031 extends past end 32856)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131897.452678.patch
Type: text/x-patch
Size: 2891 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220815/44106896/attachment.bin>
More information about the llvm-commits
mailing list