[PATCH] D131571: [AArch64][SME] Fix lowering of llvm.aarch64.get.pstatesm()

Mon Aug 15 07:50:45 PDT 2022

david-arm added inline comments.

================
Comment at: llvm/include/llvm/IR/CallingConv.h:255

+    /// Preserve X0-X13, X19-X29, SP, Z0-Z31, P0-P15.
+    AArch64_SME_ABI_Support_Routines_PreserveMost = 102,
----------------
Is this right? The ABI document in github suggests:

  X2-X15, X19-X29 and SP are call-preserved.

for `__arm_sme_state`, which is different to the comment, specifically the `X0-X13` bit.

================
Comment at: llvm/test/CodeGen/AArch64/sme-get-pstatesm.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sme -verify-machineinstrs < %s | FileCheck %s
----------------
I assume you removed this line because you chopped out some unwanted CHECK lines after running the script?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131571/new/

https://reviews.llvm.org/D131571