[PATCH] D131028: [AArch64] Fix cost model for FADD vector reduction

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 06:27:56 PDT 2022


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

I ran some perf sanity checks including SPEC2006 & SPEC2017 and a few internal test suites over the weekend and the change looks neutral, with all changes being in the noise level for my test system.

This patch LGTM, as it more accurately reflects the actual cost of fadd vector reductions on AArch64.

@dmgreen  It would be great if you could let us know if you still have concerns about the case you shared!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131028/new/

https://reviews.llvm.org/D131028



More information about the llvm-commits mailing list