[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute
Chuanqi Xu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 15 02:46:32 PDT 2022
ChuanqiXu added inline comments.
================
Comment at: clang/test/CodeGenCXX/threadlocal_address.cpp:27
// CHECK-O1-NEXT: entry:
-// CHECK-O1-NEXT: %[[I_ADDR:.+]] = {{.*}}call ptr @llvm.threadlocal.address.p0(ptr nonnull @i)
+// CHECK-O1-NEXT: %[[I_ADDR:.+]] = {{.*}}call ptr @llvm.threadlocal.address.p0(ptr @i)
// CHECK-O1-NEXT: %[[VAL:.+]] = load i32, ptr %[[I_ADDR]]
----------------
Why do we move the `nonnull` specifier here? And it looks like we need a nonnull attribute for the return value. (Same for other tests.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131872/new/
https://reviews.llvm.org/D131872
More information about the llvm-commits
mailing list