[PATCH] D131058: [AArch64] Add an error if SVE scalable vector types are used in a context without sve

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:676
+    const std::vector<std::string> &FeaturesVec) const {
+  // FIXME: This should be based on the existing feature map in the backend.
+  std::vector<std::string> UpdatedFeaturesVec;
----------------
Is it possible to address the FIXME as part of this patch? I'm a bit worried about more technical debt creeping in here, as handling the feature flags is already quite complex and replicated in different places. For example, lib/Driver/ToolChains/Arch/AArch64.cpp has a function `DecodeAArch64Features` which attempts to do something similar.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131058/new/

https://reviews.llvm.org/D131058