[PATCH] D130479: [ORC_RT][COFF] Initial platform support for COFF/x86_64.

[Mike Hommey via Phabricator via llvm-commits]

glandium added a comment.

For what it's worth, this break building compiler-rt with clang-cl:

  In file included from /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp:16:
  In file included from /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.h:17:
  In file included from /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/executor_address.h:20:
  /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/simple_packed_serialization.h(403,58): error: no member named 'string_view' 
  in namespace 'std'
  template <> class SPSSerializationTraits<SPSString, std::string_view> {
                                                      ~~~~~^
  /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(109,21): error: no type named 'string_view' in namespace '
  std'
    void *dlopen(std::string_view Name, int Mode);
                 ~~~~~^
  /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(111,34): error: no type named 'string_view' in namespace '
  std'
    void *dlsym(void *Header, std::string_view Symbol);
                              ~~~~~^
  /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(118,34): error: no member named 'string_view' in namespace
   'std'
        std::vector<std::pair<std::string_view, ExecutorAddrRange>> Secs,
                              ~~~~~^
  /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(122,34): error: no member named 'string_view' in namespace
   'std'
        std::vector<std::pair<std::string_view, ExecutorAddrRange>> Secs);
                              ~~~~~^
  /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(135,36): error: no type named 'string_view' in namespace '
  std'
    Expected<void *> dlopenImpl(std::string_view Path, int Mode);
                                ~~~~~^
  /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(143,46): error: no type named 'string_view' in namespace '
  std'
    JITDylibState *getJITDylibStateByName(std::string_view Path);
                                          ~~~~~^
  /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(145,54): error: no type named 'string_view' in namespace '
  std'
                                                  std::string_view Symbol);
                                                  ~~~~~^
  /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(156,27): error: no member named 'string_view' in namespace
   'std'
    std::unordered_map<std::string_view, void *> JDNameToHeader;
                       ~~~~~^
  /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(173,55): error: no type named 'string_view' in namespace '
  std'

etc.

The problem being that MSVC string_view header doesn't do anything unless building at least in C++17 mode, and for some reason, that's not the case. (In case it matters, this is from a standalone build of compiler-rt)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130479/new/

https://reviews.llvm.org/D130479