[PATCH] D131727: Enable -Wctad-maybe-unsupported in LLVM build

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D131727#3721466 <https://reviews.llvm.org/D131727#3721466>, @jloser wrote:

> In D131727#3721438 <https://reviews.llvm.org/D131727#3721438>, @dblaikie wrote:
>
>> In D131727#3720994 <https://reviews.llvm.org/D131727#3720994>, @philnik wrote:
>>
>>> I think libc++ shouldn't be built with `-Wctad-maybe-unsupported`, since we can generally assume that using CTAD is OK.
>>
>> Yeah, that was my feeling too but I wasn't sure where/how to disable it in the libc++ build. But I guess maybe I can add it to this list ( https://github.com/llvm/llvm-project/blob/eaf0aa1f1fbd06fbd66417f2c9d50d3074969824/libcxx/CMakeLists.txt#L592  (updated this review to include that change)) and I don't have to worry about compiler compatibility checks because libcxx uses the just-built clang, so it's not going to run against an outdated clang that'll complain that it doesn't know the warning flag?
>
> `libc++` doesn't always use the just-built clang. We keep support for the last two versions of clang, so the compiler compatibility checks would be needed, right? Was the flag added in llvm14 or llvm15?

ah, OK. Looks like this is supported back to Clang 9: https://godbolt.org/z/5rzMoKoEv (unknown name on Clang 8, no warning on Clang 9)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131727/new/

https://reviews.llvm.org/D131727