[PATCH] D131587: [CodeGen] Deduplicate restore blocks in branch relaxation

Sun Aug 14 11:29:41 PDT 2022

piggynl marked 2 inline comments as done.
piggynl added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/branch-relax-spill.ll:2036
+
+define amdgpu_kernel void @spill_duplicated_restore_block(i32 addrspace(1)* %arg, i32 %cnd) #0 {
+; CHECK-LABEL: spill_duplicated_restore_block:
----------------
piggynl wrote:
> I have no knowledge of AMDGPU and don't know how to construct some branches that can share or cann't share a same restore block, so please kindly let me know how to construct the test properly.
> 
> This is the first added function. I copied `@spill()` in this file and simply added another branch after the previous one. The two branches look to share the same restore block `.LBB2_5`.
Moved these comments about tests for AMDGPU to D131865.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131587/new/

https://reviews.llvm.org/D131587