[PATCH] D131865: Pre-commit test for D131587

[Piggy via Phabricator via llvm-commits]

piggynl added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/branch-relax-spill.ll:2036
+
+define amdgpu_kernel void @spill_duplicated_restore_block(i32 addrspace(1)* %arg, i32 %cnd) #0 {
+; CHECK-LABEL: spill_duplicated_restore_block:
----------------
I have no knowledge of AMDGPU and don't know how to construct some branches that can share or can't share a same restore block, so please kindly let me know how to construct the test properly.

This is the first added function. I copied `@spill()` in this file and simply added another branch after the previous one. The two restore blocks `.LBB2_5` and `.LBB2_7` are identical.


================
Comment at: llvm/test/CodeGen/AMDGPU/branch-relax-spill.ll:3004
+
+define void @spill_func_duplicated_restore_block(i32 addrspace(1)* %arg) #0 {
+; CHECK-LABEL: spill_func_duplicated_restore_block:
----------------
This is the second added function. I copied `@spill_func()` in this file and simply added another branch after the previous one. It seems the two branches don't share a same destination.


================
Comment at: llvm/test/CodeGen/AMDGPU/branch-relax-spill.ll:3413-3422
+; CHECK-NEXT:    s_mov_b32 vcc_hi, vcc_lo
+; CHECK-NEXT:    s_mov_b32 vcc_lo, s101
+; CHECK-NEXT:    s_mov_b32 s101, s100
+; CHECK-NEXT:    s_mov_b32 s100, s99
+; CHECK-NEXT:    s_mov_b32 s99, s98
+; CHECK-NEXT:    s_mov_b32 s98, s97
+; CHECK-NEXT:    s_mov_b32 s97, s96
----------------
and I don't know why this sequence is forming. Is this intended?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131865/new/

https://reviews.llvm.org/D131865