[PATCH] D131347: Set up basic infrastructure for ELF/i386 backend support in JITLink .

Kshitij Jain via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 14 10:13:26 PDT 2022


jain98 added a comment.

In D131347#3721558 <https://reviews.llvm.org/D131347#3721558>, @lhames wrote:

> @tschuett's suggestion is a good one.

I think so too. However, I was thinking maybe we should make that change separately and perhaps group it with similar namespace changes across other JitLink files? I'm happy to send out a code review for the same.

> Otherwise LGTM. Just let me know what name and email you would like me to use for attribution and I can land this tomorrow. :)

Name: Kshitij Jain
Email: jkshtj at outlook.com

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131347/new/

https://reviews.llvm.org/D131347



More information about the llvm-commits mailing list