[PATCH] D131816: [InstrProf] Add option to avoid instrumenting small functions

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM. Please wait a bit for others' opinions.



================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:297
+    "pgo-function-size-threshold", cl::Hidden,
+    cl::desc("Do not instrument functions smaller than this threshold."));
+
----------------
The convention is to omit the period for help messages. Just ignore a few options in this file which do not stick with the convention.


================
Comment at: llvm/test/Transforms/PGOProfile/function_size_threshold.ll:7
+
+; CHECK: define i32 @small(
+define i32 @small(i32 %i) {
----------------
CHECK-LABEL


================
Comment at: llvm/test/Transforms/PGOProfile/function_size_threshold.ll:14
+
+; CHECK: define i32 @large(
+define i32 @large(i32 %0) {
----------------
CHECK-LABEL


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131816/new/

https://reviews.llvm.org/D131816