[PATCH] D131843: llvm-reduce: remove a crash in the basic block reducing pass

[John Regehr via Phabricator via llvm-commits]

regehr created this revision.
regehr added reviewers: aeubanks, arsenm.
Herald added a project: All.
regehr requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

the previous logic was pretty badly wrong, this pass should work a lot better now


https://reviews.llvm.org/D131843

Files:
  llvm/test/tools/llvm-reduce/remove-bbs-nocrash.ll
  llvm/tools/llvm-reduce/deltas/ReduceBasicBlocks.cpp


Index: llvm/tools/llvm-reduce/deltas/ReduceBasicBlocks.cpp
===================================================================
--- llvm/tools/llvm-reduce/deltas/ReduceBasicBlocks.cpp
+++ llvm/tools/llvm-reduce/deltas/ReduceBasicBlocks.cpp
@@ -147,11 +147,9 @@
   }
 
   // Remove out-of-chunk BB from successor phi nodes
-  for (auto &F : Program) {
-    for (auto &BB : F) {
-      for (auto *Succ : successors(&BB))
-        Succ->removePredecessor(&BB);
-    }
+  for (auto &BB : BBsToDelete) {
+    for (auto *Succ : successors(BB))
+      Succ->removePredecessor(BB, /*KeepOneInputPHIs=*/true);
   }
 
   // Replace terminators that reference out-of-chunk BBs
Index: llvm/test/tools/llvm-reduce/remove-bbs-nocrash.ll
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-reduce/remove-bbs-nocrash.ll
@@ -0,0 +1,32 @@
+; RUN: llvm-reduce -abort-on-invalid-reduction --delta-passes=basic-blocks --test FileCheck --test-arg --check-prefix=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+
+; CHECK-INTERESTINGNESS: ret
+
+
+
+source_filename = "bad.ll"
+target triple = "x86_64-unknown-linux-gnu"
+
+define void @f(ptr nocapture %arg, ptr %arg1) {
+bb:
+  br i1 false, label %bb2, label %bb26
+
+bb2:                                              ; preds = %bb
+  br label %bb4
+
+bb4:                                              ; preds = %bb2
+  br label %bb5
+
+bb5:                                              ; preds = %bb5, %bb4
+  %i = phi i64 [ 0, %bb4 ], [ %i9, %bb5 ]
+  %i6 = getelementptr inbounds i64, ptr %arg, i64 %i
+  %i7 = load i64, ptr %i6, align 8
+  %i8 = getelementptr inbounds i64, ptr %arg1, i64 %i
+  store i64 0, ptr %i8, align 8
+  %i9 = add nuw nsw i64 %i, 1
+  %i10 = icmp eq i64 %i9, 0
+  br i1 %i10, label %bb26, label %bb5
+
+bb26:                                             ; preds = %bb5, %bb
+  ret void
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131843.452446.patch
Type: text/x-patch
Size: 1920 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220813/dfaa4a88/attachment.bin>