[PATCH] D131829: [ADT] Implement Optional::transform

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 13 11:14:31 PDT 2022


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sounds good - in the abstract it'd bee good not to duplicate the code or testing (old testing could be minimized if old implementation were rewritten as a wrapper around the new implementation) - but it's perhaps not enough to matter (hardly likely to have much in the way of bug fixes/changes to the testing or implementation that could diverge) and will make it simpler/easier to remove the old one later - so whatever works best for you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131829/new/

https://reviews.llvm.org/D131829



More information about the llvm-commits mailing list