[PATCH] D131376: [wasm-ld] Allow importing/exporting the output module's memory with arbitrary names

Liam Murphy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 13 02:15:39 PDT 2022


Liamolucko added a comment.

In D131376#3716714 <https://reviews.llvm.org/D131376#3716714>, @sbc100 wrote:

> In D131376#3711300 <https://reviews.llvm.org/D131376#3711300>, @Liamolucko wrote:
>
>>> 1. Are there going to be other cabi-relatated things, that warrent just putting this behind a single "cabi" flag rather than requiring N different flags for this?
>>
>> Yeah, the linker will also have to merge together `cabi_start` definitions, so using a unified flag makes more sense. I'll make a new patch to do it that way. Does Phabricator have a way to close this one?
>
> That does `cabi_start` represent?  If its the equivalent of `main` we probably don't want the linker to merge them but instead reject programs that contain more than one (just like any other symbol).

It's the component-model equivalent of WebAssembly start functions, which //can// be used for `main` but are mainly meant for initialization. Fully-fledged components are explicitly allowed to have multiple, so I think it makes sense to merge them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131376/new/

https://reviews.llvm.org/D131376



More information about the llvm-commits mailing list