[PATCH] D131728: [MSAN] add flag to suppress storage of stack variable names with -sanitize-memory-track-origins

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/msan/msan_report.cpp:40-48
+  if (so == nullptr) {
+    Printf("  %sUninitialized value was created in the stack frame%s\n",
+           d.Origin(), d.Default());
+  } else {
+    Printf(
+        "  %sUninitialized value was created by an allocation of '%s%s%s'"
+        " in the stack frame%s\n",
----------------
nits
1. we usually use implicit conversion to bool for pointers checking
2. positive branch first


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131728/new/

https://reviews.llvm.org/D131728