[PATCH] D131727: Enable -Wctad-maybe-unsupported in LLVM build

Fri Aug 12 15:23:12 PDT 2022

dblaikie marked an inline comment as done.
dblaikie added a comment.

Still open to ideas as to what to do with libc++. I mean it seems it's only a warning and not an error there, even in an `LLVM_ENABLE_WERROR` build, so maybe it can be committed as-is? But I'm not sure/wouldn't mind a libc++ developer to weigh in. (@ldionne?)

================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:795
+
+  # Enable -Wcta-maybe-unsupported to catch unintended use of CTAD.
+  add_flag_if_supported("-Wctad-maybe-unsupported" CTAD_MAYBE_UNSPPORTED_FLAG)
----------------
ChuanqiXu wrote:
> 
Thanks for the catch!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131727/new/

https://reviews.llvm.org/D131727