[PATCH] D131592: [SampleProfile] Fix non-determinism in promoteMergeNotInlinedContextSamples()

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 11:51:01 PDT 2022


dblaikie added a comment.

@rnk mentioned reverse iteration mode - have you tried that? Does it stabilize the nondeterminism at all? (nondeterminism due to hash ordering of pointers could be easily perturbed by unrelated changes causing different allocation profiles, locations, etc - but reverse iteration can stabilize that more/make the non-determinism... deterministic?)

It'd be good to have a test that fails under reverse or forward iteration and passes under the other, if possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131592/new/

https://reviews.llvm.org/D131592



More information about the llvm-commits mailing list