[PATCH] D123515: [RISCV] Support '.option arch' directive

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 09:32:07 PDT 2022


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2200
+    Parser.Lex();
+    return Parser.parseToken(AsmToken::EndOfStatement,
+                             "unexpected token, expected end of statement");
----------------
StephenFan wrote:
> jrtc27 wrote:
> > binutils allows more than one change in the same line as `.option arch, +foo, bar, -baz, +qwerty` etc
> what would `.option arch, bar` do?
That's the replacement syntax for `.option arch, =bar`, it was changed before merging to binutils


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123515/new/

https://reviews.llvm.org/D123515



More information about the llvm-commits mailing list