[PATCH] D131309: [ELF] Add ability to get a symbol by name from the hash table section

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 07:57:28 PDT 2022


yaxunl added inline comments.


================
Comment at: llvm/unittests/Object/ELFObjectFileTest.cpp:878
+    ASSERT_THAT_EXPECTED(FoundSymNameOrErr, Succeeded());
+    ASSERT_TRUE(*FoundSymNameOrErr == SymbolName);
+  }
----------------
I am wondering whether it is useful to add a test for getting symbol values here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131309/new/

https://reviews.llvm.org/D131309



More information about the llvm-commits mailing list