[PATCH] D130278: [LAA] Handle forked pointers with add/sub instructions

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.

I'm not hugely familiar with this code but I can see you're following the same idiom as used for `Instruction::GetElementPtr` which is just a special type of add so this patch looks good to me.  Please remember to run clang-format before landing the patch.



================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:930-931
+
+    ScevList.push_back(std::make_pair(GetBinOpExpr(Opcode, LScevs[0].first, RScevs[0].first), NeedsFreeze));
+    ScevList.push_back(std::make_pair(GetBinOpExpr(Opcode, LScevs[1].first, RScevs[1].first), NeedsFreeze));
+    break;
----------------
This looks to break the 80 character line length rules.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130278/new/

https://reviews.llvm.org/D130278