[PATCH] D131731: [InstCombine] Remove assumptions about int having 32 bits

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 01:28:58 PDT 2022


uabelho added a comment.

I've verified that this patch fixes the crash for ffs that we saw for a target with 16bit int. Thanks!
I have no idea about test coverage though, I think we're pretty bad at testing lib calls for our own compiler. The ffs crash was the only I saw.

So all in all, if the original patch caused other mismatches between the checks and later expectations I have no clue about really.

But this seems to be a step in the right direction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131731/new/

https://reviews.llvm.org/D131731



More information about the llvm-commits mailing list