[PATCH] D131713: [llvm][CMake] Move `split-file` from tools to utils

Markus Böck via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 00:24:50 PDT 2022


zero9178 added a comment.

In D131713#3718371 <https://reviews.llvm.org/D131713#3718371>, @jhenderson wrote:

> I tentatively agree with @MaskRay on this. Certainly, split-file is really intended for use as a test helper only. yaml2obj and obj2yaml though could have wider usage potentially (I myself have occasionally used one or the other to experiment with some things). As such, I think split-file to utils only would be best.
>
> That all being said, I've not looked at the CMake. What's the difference between `add_llvm_utility` and whatever is used for the other tools like llvm-objdump etc?

See https://reviews.llvm.org/D130977, but the gist of it is essentially what CMake flags are used to control whether a target is built as well as installed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131713/new/

https://reviews.llvm.org/D131713



More information about the llvm-commits mailing list