[PATCH] D131209: [mlgo] Add ability to create feature-gated development features in regalloc advisor

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/CodeGen/MLRegallocEvictAdvisor.cpp:334
+      : RegAllocEvictionAdvisorAnalysis(AdvisorMode::Release) {
+    InputFeatures = {RA_EVICT_FEATURES_LIST(_DECL_FEATURES)};
+  }
----------------
don't init the static in the ctor. Init it outside (i.e. it can be init-ed where it was before)

also, why make it a member? that seems unrelated change


================
Comment at: llvm/lib/CodeGen/MLRegallocEvictAdvisor.cpp:342
 private:
+  static std::vector<TensorSpec> InputFeatures;
+
----------------
no need to make it a member / or separate change.


================
Comment at: llvm/lib/CodeGen/MLRegallocEvictAdvisor.cpp:403
+      : RegAllocEvictionAdvisorAnalysis(AdvisorMode::Development) {
+    InputFeatures = {RA_EVICT_FEATURES_LIST(_DECL_FEATURES)};
+    TrainingInputFeatures = {
----------------
same as above: don't init statics in the ctor, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131209/new/

https://reviews.llvm.org/D131209