[PATCH] D131727: Enable -Wctad-maybe-unsupported in LLVM build

Thu Aug 11 15:08:51 PDT 2022

MaskRay added a comment.

Adding the warning LGTM. The summary should state what `-Wctad-maybe-unsupported` is and how it is useful.

I see that https://discourse.llvm.org/t/rfc-increasing-the-gcc-and-clang-requirements-to-support-c-17-in-llvm/59983 didn't discuss CTAD.
If there are mixed feelings, I think we should be conservative by doing this, and let folks propose CTAD to make convincing arguments not to use -Wctad-maybe-unsupported

================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:795
+
+  # Enable -Wstring-conversion to catch misuse of string literals.
+  add_flag_if_supported("-Wctad-maybe-unsupported" CTAD_MAYBE_UNSPPORTED_FLAG)
----------------
typo in comment

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131727/new/

https://reviews.llvm.org/D131727