[PATCH] D131631: [MSAN] Separate id ptr from constant string for variable names used in track origins.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/msan/msan_interface_internal.h:113
+void __msan_set_alloca_origin5(void *a, uptr size, u32 *id_ptr, char *descr,
+                               uptr pc);
+SANITIZER_INTERFACE_ATTRIBUTE
----------------
we don't need pc in this function


================
Comment at: llvm/test/Instrumentation/MemorySanitizer/alloca.ll:26
 ; CALL: call void @__msan_poison_stack(i8* {{.*}}, i64 4)
-; ORIGIN: call void @__msan_set_alloca_origin(i8* {{.*}}, i64 4,
+; ORIGIN: call void @__msan_set_alloca_origin5(i8* {{.*}}, i64 4,
 ; KMSAN: call void @__msan_poison_alloca(i8* {{.*}}, i64 4,
----------------
looks like we don't test last id and descr at all
Let's land D131721 and then you can test a new code same way


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131631/new/

https://reviews.llvm.org/D131631