[PATCH] D131716: X86: Don't fold TEST into ADD ... at GOTTPOFF/GOTNTPOFF/INDNTPOFF

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 13:57:11 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:4091
+    unsigned Flags = MI.getOperand(5).getTargetFlags();
+    if (Flags == X86II::MO_GOTTPOFF || Flags == X86II::MO_INDNTPOFF || Flags == X86II::MO_GOTNTPOFF)
+      return false;
----------------
craig.topper wrote:
> 80 columns
Can use `llvm::is_contained({...}, Flags)` to make this shorter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131716/new/

https://reviews.llvm.org/D131716



More information about the llvm-commits mailing list