[PATCH] D131716: X86: Don't fold TEST into ADD ... at GOTTPOFF/GOTNTPOFF/INDNTPOFF

[James Y Knight via Phabricator via llvm-commits]

jyknight created this revision.
jyknight added reviewers: craig.topper, MaskRay, ChuanqiXu.
Herald added subscribers: StephenFan, ThomasRaoux, pengfei, hiraditya.
Herald added a project: All.
jyknight requested review of this revision.
Herald added a reviewer: zuban32.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The linker may convert such an ADD into a LEA, so we must not
use the EFLAGS output.

This causes miscompiles with ubsan after bacdf80f42b46044262e97e98398d1bd0b75900d <https://reviews.llvm.org/rGbacdf80f42b46044262e97e98398d1bd0b75900d>
added llvm.threadlocal.address -- previously, global variables were
known to be non-null, but the intrinsic is not currently known to return
nonnull. (That should be corrected, but it shouldn't've caused
miscompiles!)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131716

Files:
  llvm/lib/Target/SPIRV/SPIRVDuplicatesTracker.cpp
  llvm/lib/Target/X86/X86InstrInfo.cpp
  llvm/test/CodeGen/X86/peephole-nofold-tpoff-x86.mir
  llvm/test/CodeGen/X86/peephole-nofold-tpoff-x86_64.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131716.451967.patch
Type: text/x-patch
Size: 9159 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220811/d9e24af2/attachment.bin>