[PATCH] D131631: [MSAN] Separate id ptr from constant string for variable names used in track origins.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/msan/msan_interface_internal.h:112
+                               uptr pc);
 SANITIZER_INTERFACE_ATTRIBUTE
 u32 __msan_chain_origin(u32 id);
----------------
vitalybuka wrote:
> we should not change interface of existing function and just add:
> void __msan_set_alloca_origin_with_name(void *a, uptr size, u32 *id_ptr, char *descr);
> 
> 
weird naming, only now I realized what if 4 stands for :)
I guess it's fine for internal call 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131631/new/

https://reviews.llvm.org/D131631