[PATCH] D125504: [AArch64] Add `foldCSELOfCSEl` DAG combine

Karl Meakin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 05:34:18 PDT 2022


Kmeakin added a comment.

In D125504#3701875 <https://reviews.llvm.org/D125504#3701875>, @samparker wrote:

> Maybe this should be done in InstCombine instead?

It may be worth adding a similar transform to InstCombine. However InstCombine cannot catch all instances of `CSEL`, because some LLVM IR intrinsics (eg `llvm.uadd.sat`) expand to `CSEL` during the lowering from LLVM IR to SelectionDAG IR: too late to be handled by InstCombine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125504/new/

https://reviews.llvm.org/D125504



More information about the llvm-commits mailing list