[PATCH] D131309: [ELF] Add ability to get a symbol by name from the hash table section

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 05:28:40 PDT 2022


jhuber6 added a comment.

In D131309#3715186 <https://reviews.llvm.org/D131309#3715186>, @jhenderson wrote:

> I think you might be reinventing the wheel here. llvm-readobj already has code for printing the symbols derived from the hash table - see `printHashTableSymbols`. Can you reuse that code? Obviously, this might require refactoring some of the llvm-readobj logic, so that it is in libObject rather than the tool specifically.

The usage is somewhat different, as far as I can tell the `llvm-readobj` implementation is only concerned with printing all the symbols in the hash table. This function is intended to be used to look up a specific symbol if we already know the name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131309/new/

https://reviews.llvm.org/D131309



More information about the llvm-commits mailing list