[PATCH] D129915: [InstCombine] Tighten up known library function signature tests (PR #56463)

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 04:14:51 PDT 2022


uabelho added a comment.

Hello,

I think there is a problem with this patch.
I made a comment here (as I didn't find this review at first :( :
https://reviews.llvm.org/rG0dcfe7aa35cd4f6dbeb739fcd05f93aa39394f0e#1114655

I short: The commit not only tightens up the lib function lib tests, it also relaxes them! So in some cases we now identify calls as lib calls that LibCallSimplifier isn't prepared for.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129915/new/

https://reviews.llvm.org/D129915



More information about the llvm-commits mailing list