[PATCH] D130121: [3/3] [COFF] Emit embedded -exclude-symbols: directives for hidden visibility for MinGW

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D130121#3714657 <https://reviews.llvm.org/D130121#3714657>, @MaskRay wrote:

> I think the lld changes (1) (2) are pretty safe to cherry pick. I like that idea that consumers support something earlier than the producers.

Yes, that sounds reasonable, (1) and (2) are safe and harmless to make available, while (3) is the one that potentially can cause surprises.

> The Chrome folks may want to analyze (3).

Not sure how much there's to analyze for them in it, as they don't use the mingw mode at all. At most, I guess they'd be concerned if the extra branches in the fast path affect performance of their linking, but I would expect that it doesn't.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130121/new/

https://reviews.llvm.org/D130121