[PATCH] D131431: [update_llc_test_checks][VE] Handle .Lfoo$local in functon regex

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

In D131431#3714480 <https://reviews.llvm.org/D131431#3714480>, @kaz7 wrote:

> Ah, Ok.  I've understood what you are trying to fix now.  You are trying to correct regexp for VE in UpdateTestChecks/asm.py.  I couldn't correct it, so I just hand-write this `builtin_sjlj_landingpad.ll` test when I created this.
>
> Thank you!
>
> In D131431#3712337 <https://reviews.llvm.org/D131431#3712337>, @arichardson wrote:
>
>> In D131431#3712222 <https://reviews.llvm.org/D131431#3712222>, @kaz7 wrote:
>>
>>> It's looks like this patch itself IS removing landing pad instructions from builtin_sjlj_landingpad.ll although the explanation of this patch is saying opposite.
>>
>> I re-ran the update script on that file, and now it correctly detects the function boundary: Everything below `.Lfunc_end0:` should not have been added as a CHECK line but because the regex was wrong before it matched everything up to the next function.
>
> I was saying that removed lines including `.LJIT0_0` and `GCC_except_table0` are the part of function `foo`.  Those are exception tables generated by llvm.  And I left them when I write this test by hand with a thought that I'd like to check the contents of exception tables.  On the other hand, you are right.  Everything below `.Lfunc_end0:` should not have been added since it is the purpose of this `UpdateTestChecks/asm.py`.  I'll find other way to check exception tables.
>
> LGTM.

Ah if you actually want to check those tables, you can add manual checks with UTC_ARGS: --disable. Will update this commit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131431/new/

https://reviews.llvm.org/D131431