[PATCH] D131518: Make opt-viewer more usable by general developers

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thank you very much for sharing those improvements!

The improvements in both UI and remark handling look very desirable in general. Some of the changes seem unrelated, would it be possible to split the patch up in multiple separate patches to make them easier to review individually? E.g. move the UI changes in one or more separate patches, individual patches for the new options, the example and so on.



================
Comment at: llvm/tools/opt-viewer/cpp_optimization_example/main.cc:1
+#include <iostream>
+#include <vector>
----------------
Adding an example is great! Ig might also be good to use it as an end-to-end-test, although this may a bit more complicated, as it would require Clang to also be built.

It would also be good to mention this example in some of our documentation.


================
Comment at: llvm/tools/opt-viewer/requirements.txt:3
+Pygments>=2.2.0
+#guppy>=0.1.11
----------------
Is this needed or not?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131518/new/

https://reviews.llvm.org/D131518