[PATCH] D131650: workflows/version-check: Fix check for release candidates

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 00:18:04 PDT 2022


thieta accepted this revision.
thieta added a comment.
This revision is now accepted and ready to land.

LGTM with one small question.



================
Comment at: .github/workflows/version-check.py:23
+        # Check if this is an rc tag.
+        m = re.match('llvmorg-([0-9]+)\.0\.0-rc[0-9]+', tag)
+        if not m:
----------------
Is it unthinkable that we would ever do a rc for a non .0.0 version? It's fine for now but we could just match [0-9] or \d here as well I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131650/new/

https://reviews.llvm.org/D131650



More information about the llvm-commits mailing list