[PATCH] D130451: [JITLink][COFF][x86_64] Stub SECREL relocation to external symbol.

Sunho Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 23:13:47 PDT 2022


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9381de095261: [JITLink][COFF][x86_64] Stub SECREL relocation to external symbol. (authored by sunho).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130451/new/

https://reviews.llvm.org/D130451

Files:
  llvm/lib/ExecutionEngine/JITLink/COFF_x86_64.cpp


Index: llvm/lib/ExecutionEngine/JITLink/COFF_x86_64.cpp
===================================================================
--- llvm/lib/ExecutionEngine/JITLink/COFF_x86_64.cpp
+++ llvm/lib/ExecutionEngine/JITLink/COFF_x86_64.cpp
@@ -161,6 +161,9 @@
       break;
     }
     case COFF::RelocationTypeAMD64::IMAGE_REL_AMD64_SECREL: {
+      // FIXME: SECREL to external symbol should be handled
+      if (!GraphSymbol->isDefined())
+        return Error::success();
       Kind = EdgeKind_coff_x86_64::SecRel32;
       Addend = *reinterpret_cast<const support::little32_t *>(FixupPtr);
       break;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130451.451736.patch
Type: text/x-patch
Size: 601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220811/af96cc80/attachment.bin>


More information about the llvm-commits mailing list